[libvirt] [PATCH] pci: Read bridge control register from the bridge
Eric Blake
eblake at redhat.com
Fri Aug 31 18:16:18 UTC 2012
On 08/31/2012 07:17 AM, Osier Yang wrote:
> Though I don't quite understand it well enough, but it looks
> wrong to read the control register from the device, and then
> write to its parent twice, while doing the secondary bus reset.
> ---
> src/util/pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/util/pci.c b/src/util/pci.c
> index 0742d07..c3f1b2b 100644
> --- a/src/util/pci.c
> +++ b/src/util/pci.c
> @@ -642,7 +642,7 @@ pciTrySecondaryBusReset(pciDevice *dev,
> /* Read the control register, set the reset flag, wait 200ms,
> * unset the reset flag and wait 200ms.
> */
> - ctl = pciRead16(dev, PCI_BRIDGE_CONTROL);
> + ctl = pciRead16(parent, PCI_BRIDGE_CONTROL);
ACK. Unfortunately, I, like you, have no idea how to really test this,
and am reviewing solely based on the code comments.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 617 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120831/bf6e5c59/attachment-0001.sig>
More information about the libvir-list
mailing list