[libvirt] [PATCH] qemu: improve error for failed JSON commands

Peter Krempa pkrempa at redhat.com
Tue Dec 4 20:46:12 UTC 2012


On 12/04/12 21:26, Eric Blake wrote:
> Only one error in qemu_monitor was already using the relatively
> new OPERATION_UNSUPPORTED error, even though it is a better fit
> for all of the messages related to options that are unsupported
> due to the version of qemu in use rather than due to a user's
> XML or .conf file choice.  Suggested by Osier Yang.
>
> * src/qemu/qemu_monitor.c (qemuMonitorSendFileHandle)
> (qemuMonitorAddHostNetwork, qemuMonitorRemoveHostNetwork)
> (qemuMonitorAttachDrive, qemuMonitorDiskSnapshot)
> (qemuMonitorDriveMirror, qemuMonitorTransaction)
> (qemuMonitorBlockCommit, qemuMonitorDrivePivot)
> (qemuMonitorBlockJob, qemuMonitorSystemWakeup)
> (qemuMonitorGetVersion, qemuMonitorGetMachines)
> (qemuMonitorGetCPUDefinitions, qemuMonitorGetCommands)
> (qemuMonitorGetEvents, qemuMonitorGetKVMState)
> (qemuMonitorGetObjectTypes, qemuMonitorGetObjectProps)
> (qemuMonitorGetTargetArch): Use better error category.
> ---
>   src/qemu/qemu_monitor.c |   40 ++++++++++++++++++++--------------------
>   1 files changed, 20 insertions(+), 20 deletions(-)
>

ACK.

Peter




More information about the libvir-list mailing list