[libvirt] [PATCH 4/5] qemu: reuse qemuMigrationIsAllowed when doing save and managedsave

Peter Krempa pkrempa at redhat.com
Fri Dec 7 11:30:02 UTC 2012


Save and managedsave use both migration to file. This patch reuses
qemuMigrationIsAllowed to check if the migration could happen before
trying.
---
 src/qemu/qemu_driver.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 4423e69..7e19cdc 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -3010,11 +3010,9 @@ qemuDomainSaveInternal(virQEMUDriverPtr driver, virDomainPtr dom,
                        "%s", _("domain is marked for auto destroy"));
         goto cleanup;
     }
-    if (virDomainHasDiskMirror(vm)) {
-        virReportError(VIR_ERR_BLOCK_COPY_ACTIVE, "%s",
-                       _("domain has active block copy job"));
+
+    if (!qemuMigrationIsAllowed(driver, vm, vm->def, false))
         goto cleanup;
-    }

     if (qemuDomainObjBeginAsyncJobWithDriver(driver, vm,
                                              QEMU_ASYNC_JOB_SAVE) < 0)
-- 
1.8.0




More information about the libvir-list mailing list