[libvirt] [PATCH] S390: Fix virSysinfoRead memory corruption

Viktor Mihajlovski mihajlov at linux.vnet.ibm.com
Wed Dec 12 16:10:42 UTC 2012


On 12/07/2012 06:57 PM, Eric Blake wrote:
>
>
> No.  Don't use index(), as it is not guaranteed to exist.
>
> What we should _really_ do is provide a change in
> m4/virt-compile-warnings.m4 that disables -Wlogical-op if compiling with
> a broken gcc, now that newer gcc doesn't force its stupidity on a
> sensible strchr() usage.  I'll attempt that patch independently, and
> then your patch can go on top using strchr() from the get-go.
>

On a second thought I didn't like to disable the warning
for all sources as I still would like to be informed about
potential issues.
I've send out a new version of the patch (in fact a new series)
disabling the warning with a pragma only in the affected file.

-- 

Mit freundlichen Grüßen/Kind Regards
    Viktor Mihajlovski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294




More information about the libvir-list mailing list