[libvirt] [PATCH] daemon: Preface polkit error output with 'polkit:'
Cole Robinson
crobinso at redhat.com
Sun Dec 16 23:15:37 UTC 2012
There's been a few bugs about an expected error from polkit:
https://bugzilla.redhat.com/show_bug.cgi?id=873799
https://bugzilla.redhat.com/show_bug.cgi?id=872166
The error is:
Authorization requires authentication but no agent is available.
The error means that polkit needs a password, but there is no polkit
agent registered in your session. Polkit agents are the bit of UI that
pop up and actually ask for your password.
Preface the error with the string 'polkit:' so folks can hopefully
make more sense of it.
---
daemon/remote.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/daemon/remote.c b/daemon/remote.c
index 41b8ea8..f85dae0 100644
--- a/daemon/remote.c
+++ b/daemon/remote.c
@@ -2887,9 +2887,10 @@ error:
if (authdismissed) {
virReportError(VIR_ERR_AUTH_CANCELLED, "%s",
_("authentication cancelled by user"));
+ } else if (pkout && *pkout) {
+ virReportError(VIR_ERR_AUTH_FAILED, "polkit: %s", pkout);
} else {
- virReportError(VIR_ERR_AUTH_FAILED, "%s",
- pkout && *pkout ? pkout : _("authentication failed"));
+ virReportError(VIR_ERR_AUTH_FAILED, "%s", _("authentication failed"));
}
VIR_FREE(pkout);
--
1.8.0.2
More information about the libvir-list
mailing list