[libvirt] [PATCHv3 2/3] S390: Fix virSysinfoRead memory corruption

[Eric Blake]

On 12/14/2012 08:08 AM, Viktor Mihajlovski wrote:
> There was a double free issue caused by virSysinfoRead on s390,
> as the same manufacturer string instance was assigned to more
> than one processor record.
> Cleaned up other potential memory issues and restructured the sysinfo
> parsing code by moving repeating patterns into a helper function.
> 

> +# if BROKEN_GCC_WLOGICALOP
> +# pragma GCC diagnostic ignored "-Wlogical-op"
> +# endif

Do you have cppi installed?  If so, I'm surprised this passed 'make
syntax-check'.  The middle line should be indented further as:

# if ...
#  pragma ...
# endif

to keep cppi happy.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20121218/ea91ddac/attachment-0001.sig>