[libvirt] [PATCH v3 1/5] virDomainGetDiskErrors public API
Eric Blake
eblake at redhat.com
Wed Feb 1 03:37:40 UTC 2012
On 01/31/2012 12:26 PM, Jiri Denemark wrote:
> We already provide ways to detect when a domain has been paused as a
> result of I/O error, but there was no way of getting the exact error or
> even the device that experienced it. This new API may be used for both.
> ---
> include/libvirt/libvirt.h.in | 32 ++++++++++++++++++++
> python/generator.py | 3 +-
> src/driver.h | 7 ++++
> src/libvirt.c | 65 ++++++++++++++++++++++++++++++++++++++++++
> src/libvirt_public.syms | 1 +
> 5 files changed, 107 insertions(+), 1 deletions(-)
>
> + *
> + * Since calling virDomainGetDiskErrors(dom, NULL, 0, 0) to get preferred size
> + * of @errors array and getting the errors are two separate operations, new
> + * disks may be hotplugged to the domain and new errors may be encountered
> + * between the two calls. Thus, this function may not return all disk errors
> + * because the supplied array is not large enough. Such errors may, however,
> + * be detected by listening to domain events.
I like it. Nice improvement from v1. ACK.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120131/c5ac4682/attachment-0001.sig>
More information about the libvir-list
mailing list