[libvirt] [PATCH] qemu: Clenup qemuDomainSetInterfaceParameters

Michal Privoznik mprivozn at redhat.com
Wed Feb 1 08:06:55 UTC 2012


On 01.02.2012 01:30, Eric Blake wrote:
> On 01/31/2012 05:51 AM, Michal Privoznik wrote:
>> which contained some useless lines, copied code, NULL
>> dereference.
>> ---
>>  src/libvirt.c          |    4 ++--
>>  src/qemu/qemu_driver.c |   44 ++++++++++++++++----------------------------
>>  2 files changed, 18 insertions(+), 30 deletions(-)
>>
>> diff --git a/src/libvirt.c b/src/libvirt.c
>> index e702a34..433ae0a 100644
>> --- a/src/libvirt.c
>> +++ b/src/libvirt.c
>> @@ -7226,8 +7226,8 @@ error:
>>   *
>>   * Change a subset or all parameters of interface; currently this
>>   * includes bandwidth parameters.  The value of @flags should be
>> - * either VIR_DOMAIN_AFFECT_CURRENT, or a bitwise-or of values from
>> - * VIR_DOMAIN_AFFECT_LIVE and VIR_DOMAIN_AFFECT_CURRENT, although
>> + * either VIR_DOMAIN_AFFECT_CURRENT, or a bitwise-or of values
>> + * VIR_DOMAIN_AFFECT_LIVE and VIR_DOMAIN_AFFECT_CONFIG, although
> 
> It took me a couple reads to see what typo you were fixing :)
> 
> ACK.
> 

Yeah, I've to do the same as I forgot it overnight too :)

Thanks, pushed.




More information about the libvir-list mailing list