[libvirt] [PATCH 2/2] qemu: Always use iohelper for dumping domain core
Jiri Denemark
jdenemar at redhat.com
Mon Feb 6 14:51:04 UTC 2012
Qemu uses non-blocking I/O which doesn't play nice with regular file
descriptors. We need to pass a pipe to qemu instead, which can easily be
done using iohelper.
---
src/qemu/qemu_driver.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 01dbcd7..86d3058 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -2960,8 +2960,7 @@ doCoreDump(struct qemud_driver *driver,
NULL, NULL)) < 0)
goto cleanup;
- if (bypass_cache &&
- (wrapperFd = virFileWrapperFdNew(&fd, true, path)) == NULL)
+ if (!(wrapperFd = virFileWrapperFdNew(&fd, bypass_cache, path)))
goto cleanup;
if (qemuMigrationToFile(driver, vm, fd, 0, path,
--
1.7.8.4
More information about the libvir-list
mailing list