[libvirt] [PATCH v3] virsh: Do not check the input XML at virsh layer for cmdDetachDevice

Eric Blake eblake at redhat.com
Tue Feb 7 16:16:51 UTC 2012


On 02/07/2012 09:39 AM, Osier Yang wrote:
> Any device XML doesn't use the same order as libvirt generates, or
> uses decimal for attributes like "slot" of "<address>" will cause
> device detaching to fail, as virsh compares the XML simply earlier
> in strict manner before internal parsing.
> 
> This is regression introduced by ea7182c.
> 
> v1 is here:
> https://www.redhat.com/archives/libvir-list/2012-January/msg00395.html
> 
> ---
>  tools/virsh.c |   23 +++++------------------
>  1 files changed, 5 insertions(+), 18 deletions(-)

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120207/607645b8/attachment-0001.sig>


More information about the libvir-list mailing list