[libvirt] [PATCHv3 0/2] qemu: mitigate 'qemu disk buffers not flushed' problem

Eric Blake eblake at redhat.com
Tue Feb 7 18:26:32 UTC 2012


On 02/07/2012 10:18 AM, Laine Stump wrote:
> These two patches do two things:
> 
> 1) Drop the driver lock while sleeping during qemuProcessKill(), so
> that it can wait for a longer period without locking up all other
> libvirtd threads.
> 
> This patch is a slight re-work of a patch Eric sent to the list back
> in November.

I like how you changed things to only unlock once, compared to my first
attempt.

> 
> 2) Wait for a considerably longer period after sending SIGTERM before
> sending SIGKILL. 

ACK series from me; although I'm a bit biased (having written half the
first patch before you reworked it), so you still might feedback from
danpb before pushing.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120207/e267a77f/attachment-0001.sig>


More information about the libvir-list mailing list