[libvirt] [PATCH v2 0/2] qemu: Fix stalls during live core dump
Eric Blake
eblake at redhat.com
Tue Feb 7 21:40:32 UTC 2012
On 02/07/2012 05:17 AM, Jiri Denemark wrote:
> Qemu uses non-blocking I/O which doesn't play nice with regular file
> descriptors. We need to pass a pipe to qemu when dumping core to avoid
> stalls in live mode.
>
> Version 2:
> - generalize virFileDirectFd a bit more as suggested by Eric
>
> Jiri Denemark (2):
> util: Generalize virFileDirectFd
> qemu: Always use iohelper for dumping domain core
>
> src/qemu/qemu_driver.c | 45 +++++++++++--------
> src/util/virfile.c | 118 +++++++++++++++++++++++++++++-------------------
> src/util/virfile.h | 21 ++++++---
> 3 files changed, 112 insertions(+), 72 deletions(-)
ACK series. I'm still not sure whether 'virsh save' needs EAGAIN
wrapping, but I'm okay delaying that to a separate patch, since you
convinced me that the primary driving factor for this patch is 'virsh
dump --live' where qemu will continue on after the dump.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120207/acb8639d/attachment-0001.sig>
More information about the libvir-list
mailing list