[libvirt] [PATCH 1/2] seclabel: Do not output relabel attribute for type 'none'
Jiri Denemark
jdenemar at redhat.com
Wed Feb 8 11:06:35 UTC 2012
On Tue, Feb 07, 2012 at 13:31:39 -0700, Eric Blake wrote:
> On 02/07/2012 01:10 PM, Jiri Denemark wrote:
> > Security label type 'none' requires relabel to be set to 'no' so there's
> > no reason to output this extra attribute. Moreover, since relabel is
> > internally stored in a negative from (norelabel), the default value for
> > relabel would be 'yes' in case there is no <seclabel> element in domain
> > configuration. In case VIR_DOMAIN_SECLABEL_DEFAULT turns into
> > VIR_DOMAIN_SECLABEL_NONE, we would incorrectly output relabel='yes' for
> > seclabel type 'none'.
> > ---
> > src/conf/domain_conf.c | 9 +++++----
> > .../qemuxml2argv-seclabel-none.xml | 2 +-
> > 2 files changed, 6 insertions(+), 5 deletions(-)
>
> ACK.
Pushed, thanks.
Jirka
More information about the libvir-list
mailing list