[libvirt] [PATCH] virsh: Fix flag semantics and docs for "desc" command

Peter Krempa pkrempa at redhat.com
Wed Feb 8 15:41:08 UTC 2012


On 02/08/2012 04:07 PM, Eric Blake wrote:
> On 02/08/2012 05:16 AM, Peter Krempa wrote:
>> This patch fixes the domain modification impact flags for tie virsh
>> desc command to match the new semantics and fix the docs to match
>> actual behavior.
>> ---
>>   tools/virsh.c   |   21 +++++++++++++++------
>>   tools/virsh.pod |   12 +++++-------
>>   2 files changed, 20 insertions(+), 13 deletions(-)
>>
>
>> +++ b/tools/virsh.pod
>> @@ -435,7 +435,7 @@ Define a domain from an XML<file>. The domain definition is registered
>>   but not started.  If domain is already running, the changes will take
>>   effect on the next boot.
>>
>> -=item B<desc>  [I<--live>  | I<--config>] [I<--title>] [I<--edit>]
>> +=item B<desc>  [[I<--live>  I<--config>  | I<--current>] [I<--title>] [I<--edit>]
>
> Missing some []; should be:
>
> [[I<--live>] [I<--config>] | [I<--current>]] ...
>
> ACK with that fixed.
>

Fixed & pushed. Thanks!

Peter




More information about the libvir-list mailing list