[libvirt] [PATCH 1/3] Introduce virDomainPMWakeup API
Eric Blake
eblake at redhat.com
Fri Feb 10 20:27:46 UTC 2012
On 02/10/2012 11:56 AM, Eric Blake wrote:
> On 02/10/2012 06:43 AM, Michal Privoznik wrote:
>> This API allows a domain which previously called
>> virDomainPMSuspendForDuration() to be woken up.
>> ---
>> include/libvirt/libvirt.h.in | 2 +
>> src/driver.h | 4 +++
>> src/libvirt.c | 50 ++++++++++++++++++++++++++++++++++++++++++
>> src/libvirt_public.syms | 1 +
>> src/remote/remote_driver.c | 1 +
>> src/remote/remote_protocol.x | 8 ++++++-
>> src/remote_protocol-structs | 5 ++++
>> 7 files changed, 70 insertions(+), 1 deletions(-)
>
> I don't like the thought of adding new API post-freeze without good
> reason, but I think this is a case of good reason - we are already
> committing to adding a new feature in virDomainPMSuspendForDuration, and
> that feature will be broken by design for 2 of its 3 targets unless we
> also add this counterpart. On that basis, I will review this series and
> request that you include them prior to 0.9.10.
Before you push anything, let's first consider Dave's proposal [1] of
adding a fourth PM state and slightly renaming the existing
virDomainPMSuspendForDuration over to a more-encompassing
virDomainPMSetPowerStateForDuration - if we go that route, this new API
would not be appropriate, and the qemu work in 3/3 would have be tweaked
slightly.
[1] https://www.redhat.com/archives/libvir-list/2012-February/msg00548.html
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120210/ec9f7992/attachment-0001.sig>
More information about the libvir-list
mailing list