[libvirt] [PATCHv3] python: Fix problems of virDomain{Set, Get}BlkioParameters bindings

Eric Blake eblake at redhat.com
Sat Feb 11 00:18:49 UTC 2012


On 02/10/2012 05:10 PM, Eric Blake wrote:
> On 02/10/2012 02:41 AM, ajia at redhat.com wrote:
>> From: Alex Jia <ajia at redhat.com>
>>
>> The parameter 'device_weight' is a string, however, the 'VIR_TYPED_PARAM_STRING'
>> type condition is missed by libvirt_virDomain{Set, Get}BlkioParameters bindings,
>> the result is we can't get or change 'device_weight' value.
>>

>> +    int nparams = 0, size = 0;
> 
> size should be Py_ssize_t.
> 
> ACK with that change.

Actually, it looks like Guannan's patch covers yours.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120210/34d2c7b4/attachment-0001.sig>


More information about the libvir-list mailing list