[libvirt] [PATCH] qemu: make block io tuning smarter
Eric Blake
eblake at redhat.com
Mon Feb 13 17:47:15 UTC 2012
On 02/13/2012 12:01 AM, Osier Yang wrote:
> On 02/11/2012 05:56 AM, Eric Blake wrote:
>> When blkdeviotune was first committed in 0.9.8, we had the limitation
>> that setting one value reset all others. But bytes and iops should
>> be relatively independent. Furthermore, setting tuning values on
>> a live domain followed by dumpxml did not output the new settings.
>>
>> * src/qemu/qemu_driver.c (qemuDiskPathToAlias): Add parameter, and
>> update callers.
>> (qemuDomainSetBlockIoTune): Don't lose previous unrelated
>> settings. Make live changes reflect to dumpxml output.
>> * tools/virsh.pod (blkdeviotune): Update documentation.
>> ---
>> src/qemu/qemu_driver.c | 45
>> +++++++++++++++++++++++++++++++++++++++++----
>> tools/virsh.pod | 5 +++--
>> 2 files changed, 44 insertions(+), 6 deletions(-)
>>
>>
>> -When setting any value, all remaining values are reset to unlimited,
>> -an explicit 0 also clears any limit. A non-zero value for a given total
>> +Bytes and iops values are independent, but setting only one value (such
>> +as --read_bytes_sec) resets the other two in that category to unlimited.
>> +An explicit 0 also clears any limit. A non-zero value for a given total
>> cannot be mixed with non-zero values for read or write.
>>
>> If I<--live> is specified, affect a running guest.
>
> ACK
Thanks; pushed.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120213/7182747e/attachment-0001.sig>
More information about the libvir-list
mailing list