[libvirt] [PATCH] Improve error reporting when virsh console is run without a TTY
Jiri Denemark
jdenemar at redhat.com
Wed Feb 15 14:03:48 UTC 2012
On Wed, Feb 15, 2012 at 13:16:05 +0000, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> If attempting to run
>
> ssh root at somehost virsh console someguest
>
> You'll get an error
>
> 2012-02-15 13:11:47.683+0000: 4765: info : libvirt version: 0.9.10, package: 1.fc18 (Unknown, 2012-02-15-11:48:57, lettuce.camlab.fab.redhat.com)
> 2012-02-15 13:11:47.683+0000: 4765: error : vshRunConsole:320 : unable to get tty attributes: Invalid argument
> Connected to domain f16x86_64
> Escape character is ^]
>
> There are several problems here
>
> - The actual error message is bad for users
> - We shouldn't rely on VIR_ERROR for this case
> - The prompt makes it look like we still connected
> because we didn't flush stdout.
>
> * virsh.c: Flush stdout before starting console and check
> for a valid tty
> ---
> tools/virsh.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
ACK
Jirka
More information about the libvir-list
mailing list