[libvirt] [PATCHv2] qemu: Prevent crash of libvirtd without guest agent

Alex Jia ajia at redhat.com
Thu Feb 16 15:22:34 UTC 2012


Thanks and pushed.

----- Original Message -----
From: "Jiri Denemark" <jdenemar at redhat.com>
To: ajia at redhat.com
Cc: libvir-list at redhat.com
Sent: Thursday, February 16, 2012 9:40:13 PM
Subject: Re: [libvirt] [PATCHv2] qemu: Prevent crash of libvirtd without guest agent

On Thu, Feb 16, 2012 at 10:54:40 +0800, ajia at redhat.com wrote:
> From: Alex Jia <ajia at redhat.com>
> 
> * src/qemu/qemu_process.c (qemuFindAgentConfig): avoid crash libvirtd due to
> deref a NULL pointer.
> 
> * How to reproduce?
> 1. virsh edit the following xml into guest configuration:
>     <channel type='pty'>
>       <target type='virtio'/>
>     </channel>
> 2. virsh start <domain>
> 
> or
> % virt-install -n foo -r 1024 --disk path=/var/lib/libvirt/images/foo.img,size=1 \
> --channel pty,target_type=virtio -l <installation tree>
> 
> Signed-off-by: Alex Jia <ajia at redhat.com>
> ---
>  src/qemu/qemu_process.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

ACK

Jirka




More information about the libvir-list mailing list