[libvirt] [PATCH v4 3/7] virsh: add support for VIR_DOMAIN_CONSOLE_* flags

Eric Blake eblake at redhat.com
Wed Feb 22 20:14:30 UTC 2012

On 02/06/2012 06:50 AM, Peter Krempa wrote:
> This patch adds support for the newly introduced
> command now has an optional parameter --force that specifies that the
> user wants to forcibly interrupt an ongoing console session and create
> a new one. Flag --safe requests that the console should be opened only
> if the hypervisor driver supports safe console handling.
> The behaviour to this point was that the daemon opened two streams to
> the console, that competed for data from the pipe, and the result was
> that both of the consoles ended up scrambled.
> This patch doesn't modify operation of other commands dealing with
> console connections (start, create) as those open connections to newly
> started domains making it virtualy impossible for another client to race


ACK.  And sorry for dragging this review on for so long - I promise to
finish it today ;)

Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120222/95b87bb2/attachment-0001.sig>

More information about the libvir-list mailing list