[libvirt] [PATCH] Misleading error message when name is missing

Benjamin Cama benoar at dolka.fr
Thu Feb 23 16:37:30 UTC 2012


[forwarding this here from RH bug #796732]

When creating a network (virsh net-create) with an erroneous XML
containing an empty <name> element, the error message is misleading:

error: Failed to create network from foo.xml
error: missing domain name information

It took me a bit of time to figure out that it was the *network* name
that was missing (I generate this xml and didn't look at it, first).

I realized that the same message is used for missing name when creating
a domain, network, or device node. Attached patch (warning: against a
completly different git than yours, don't pay attention to wrong shas)
thus make this message more generic.


PS: please Cc me, I'm not subscribed
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-no-name-error-message.patch
Type: text/x-patch
Size: 647 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120223/38982365/attachment-0001.bin>

More information about the libvir-list mailing list