[libvirt] [PATCH 7/7] tests: Add tests for virtio-scsi and ibmvscsi controllers

Osier Yang jyang at redhat.com
Tue Feb 28 06:31:32 UTC 2012


On 2012年02月28日 01:41, Eric Blake wrote:
> On 02/27/2012 04:59 AM, Osier Yang wrote:
>> ---
>>   .../qemuxml2argv-disk-scsi-virtio-scsi.args        |    9 +++++
>>   .../qemuxml2argv-disk-scsi-virtio-scsi.xml         |   32 ++++++++++++++++++++
>>   .../qemuxml2argv-disk-scsi-vscsi.args              |    8 +++++
>>   .../qemuxml2argv-disk-scsi-vscsi.xml               |   32 ++++++++++++++++++++
>>   tests/qemuxml2argvtest.c                           |    4 ++
>>   tests/qemuxml2xmltest.c                            |    4 ++-
>>   6 files changed, 88 insertions(+), 1 deletions(-)
>>   create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-virtio-scsi.args
>>   create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-virtio-scsi.xml
>>   create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-vscsi.args
>>   create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-vscsi.xml
>
> OK, I think this fixes most of my comment on 4/7; but I still don't see
> any non-zero target='1' entries in the new tests.
>
> If you fix Paolo's nits, as well as enhance that aspect of the tests,
> then you have my:
>
> ACK series.
>

Updates these 2 new tests with "target != 0" for no "lsilogic" scsi
type controllers. And pushed.

Thanks for the reviewing!

Osier




More information about the libvir-list mailing list