[libvirt] [libvirt-glib 4/6] Add 'config' property to GVirDomainDevice

Christophe Fergeau cfergeau at redhat.com
Wed Feb 29 13:11:23 UTC 2012


The code to add the property looks good to me except for one minor nit, see
below.
I'd rather to see patch 6/6 come right after it since I was wondering how
config was getting set.

On Tue, Feb 28, 2012 at 08:25:05PM +0200, Zeeshan Ali (Khattak) wrote:
> @@ -144,3 +166,13 @@ virDomainPtr gvir_domain_device_get_domain_handle(GVirDomainDevice *self)
>  GVirDomain *gvir_domain_device_get_domain(GVirDomainDevice *device) {
>      return g_object_ref (device->priv->domain);
>  }
> +
> +/**
> + * gvir_domain_device_get_config:
> + * @device: the domain device
> + *
> + * Returns: (transfer full): the config
> + */
> +GVirConfigDomainDevice *gvir_domain_device_get_config(GVirDomainDevice *device) {

{ on a new line

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120229/ec340214/attachment-0001.sig>


More information about the libvir-list mailing list