[libvirt] [PATCH] virsh: Fix checking for reconnect conditions

[Peter Krempa]

On 01/02/2012 05:47 PM, Eric Blake wrote:
> On 01/02/2012 09:15 AM, Peter Krempa wrote:
>> virshReportError() function frees the most recent error reported from
>> libvirt. Condition that checks if connection to the daemon was broken
>> during last command was then limited to check for SIGPIPE signal not
>> taking into account possible errors signalized without SIGPIPE.
>>
>> This patch moves the check before the error is freed, to take into
>> account code that does not emit SIGPIPE while failing.
>>
>> * tools/virsh.c: - move check for broken connection before error print.
>> ---
>> +        if (!ret&&  disconnected != 0)
>>               vshReconnect(ctl);
>>
>> +
>>           if (STREQ(cmd->def->name, "quit"))        /* hack ... */
>
> Why the blank line added there?  ACK with that nit fixed.

Ugh. I didn't notice that. Thanks. Fixed && pushed.

Peter

>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list