[libvirt] [PATCH] command: Discard FD_SETSIZE limit for opened files

Eric Blake eblake at redhat.com
Tue Jan 3 16:33:03 UTC 2012


On 01/03/2012 04:14 AM, Michal Privoznik wrote:
> Currently, virCommand implementation uses FD_ macros from
> sys/select.h. However, those cannot handle more opened files
> than FD_SETSIZE. Therefore switch to generalized implementation
> based on array of integers.
> ---
>  src/util/command.c |  108 ++++++++++++++++++++++++++++++++++++++++------------
>  1 files changed, 83 insertions(+), 25 deletions(-)

NACK.  While I agree with the idea, I'd rather use virBitmap rather than
open-coding an int array ourselves.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120103/23396a7a/attachment-0001.sig>


More information about the libvir-list mailing list