[libvirt] [PATCH] docs: Add missed RNG schema for interface
Laine Stump
laine at laine.org
Wed Jan 11 17:25:57 UTC 2012
On 01/11/2012 08:39 AM, Osier Yang wrote:
> We support<interface> of type "mcast", "server", and "client",
> but the RNG schema for them are missed.
Right you are! ACK. (A test case with one of each in the xml2argv test
would be nice, though - that would have prevented this omission.
anticipatory ACK on adding that to this patch before you push.)
(did you actually use this type of interface? It's, um, interesting I
guess, but sounds pretty inefficient.)
> ---
> docs/schemas/domaincommon.rng | 44 +++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 44 insertions(+), 0 deletions(-)
>
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index e93ae77..2caa781 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -1295,6 +1295,50 @@
> <ref name="interface-options"/>
> </interleave>
> </group>
> +<group>
> +<attribute name="type">
> +<value>mcast</value>
> +</attribute>
> +<element name="source">
> +<attribute name="address">
> +<ref name="ipv4Addr"/>
> +</attribute>
> +<attribute name="port">
> +<ref name="PortNumber"/>
> +</attribute>
> +<empty/>
> +</element>
> +</group>
> +<group>
> +<attribute name="type">
> +<value>client</value>
> +</attribute>
> +<element name="source">
> +<attribute name="address">
> +<ref name="ipv4Addr"/>
> +</attribute>
> +<attribute name="port">
> +<ref name="PortNumber"/>
> +</attribute>
> +<empty/>
> +</element>
> +</group>
> +<group>
> +<attribute name="type">
> +<value>server</value>
> +</attribute>
> +<element name="source">
> +<optional>
> +<attribute name="address">
> +<ref name="ipv4Addr"/>
> +</attribute>
> +</optional>
> +<attribute name="port">
> +<ref name="PortNumber"/>
> +</attribute>
> +<empty/>
> +</element>
> +</group>
> </choice>
> </element>
> </define>
More information about the libvir-list
mailing list