[libvirt] [PATCH 4/4] conf: Remove do-nothing validation functions
Eric Blake
eblake at redhat.com
Fri Jan 13 23:25:47 UTC 2012
On 01/12/2012 08:39 PM, Michael Ellerman wrote:
> There are three address validation routines that do nothing:
> virDomainDeviceDriveAddressIsValid()
> virDomainDeviceUSBAddressIsValid()
> virDomainDeviceVirtioSerialAddressIsValid()
>
> Remove them, and replace their call sites with "1" which is what they
> currently return. In some cases this means we can remove an entire
> if block.
They've been no-ops for a LOOONG time, and I don't see us ever needing
to revive them (and even if we did, we have git log to tell us what they
were). Thanks for doing this housecleaning.
>
> Signed-off-by: Michael Ellerman <michael at ellerman.id.au>
> ---
> src/conf/domain_conf.c | 36 ++----------------------------------
> src/conf/domain_conf.h | 3 ---
> 2 files changed, 2 insertions(+), 37 deletions(-)
ACK and pushed.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120113/4e9c4963/attachment-0001.sig>
More information about the libvir-list
mailing list