[libvirt] [PATCH v4] Add new attribute wrpolicy to <driver> element

Deepak C Shetty deepakcs at linux.vnet.ibm.com
Wed Jan 18 04:58:01 UTC 2012


On 01/18/2012 04:07 AM, Eric Blake wrote:
>
> You had lots of trailing whitespace, caught by 'make syntax-check'.
>
>> +++ b/tests/qemuxml2argvdata/qemuxml2argv-fs9p.args
>> @@ -4,10 +4,10 @@ unix:/tmp/test-monitor,server,nowait -no-acpi -boot c -hda \
>>   /dev/HostVG/QEMUGuest1 -fsdev local,security_model=passthrough,id=fsdev-fs0,\
>>   path=/export/to/guest -device virtio-9p-pci,id=fs0,fsdev=fsdev-fs0,\
>>   mount_tag=/import/from/host,bus=pci.0,addr=0x3 \
>> --fsdev local,security_model=mapped,id=fsdev-fs1,\
>> +-fsdev local,security_model=mapped,writeout=immediate,id=fsdev-fs1,\
>>   path=/export/to/guest2 -device virtio-9p-pci,id=fs1,fsdev=fsdev-fs1,\
> Excellent - that's what I was looking for in an added test.
>
> ACK after fixing up the whitespace and one other test failure, so I
> pushed with this squashed in:
>

Thanks Eric, will make sure I run the syntax-check next time.




More information about the libvir-list mailing list