[libvirt] [PATCHv2 6/6] error: drop old-style error reporting
Daniel P. Berrange
berrange at redhat.com
Thu Jan 19 18:47:48 UTC 2012
On Thu, Jan 19, 2012 at 11:44:46AM -0700, Eric Blake wrote:
> While we still don't want to enable gcc's new -Wformat-literal
> warning, I found a rather easy case where the warning could be
> reduced, by getting rid of obsolete error-reporting practices.
> This is the last place where we were passing the (unused) net
> and conn arguments for constructing an error.
>
> * src/util/virterror_internal.h (virErrorMsg): Delete prototype.
> (virReportError): Delete macro.
> * src/util/virterror.c (virErrorMsg): Make static.
> * src/libvirt_private.syms (virterror_internal.h): Drop export.
> * src/util/conf.c (virConfError): Convert to macro.
> (virConfErrorHelper): New function, and adjust error calls.
> * src/xen/xen_hypervisor.c (virXenErrorFunc): Delete.
> (xenHypervisorGetSchedulerType)
> (xenHypervisorGetSchedulerParameters)
> (xenHypervisorSetSchedulerParameters)
> (xenHypervisorDomainBlockStats)
> (xenHypervisorDomainInterfaceStats)
> (xenHypervisorDomainGetOSType)
> (xenHypervisorNodeGetCellsFreeMemory, xenHypervisorGetVcpus):
> Update callers.
> ---
> src/libvirt_private.syms | 1 -
> src/util/conf.c | 22 ++---
> src/util/virterror.c | 2 +-
> src/util/virterror_internal.h | 8 --
> src/xen/xen_hypervisor.c | 164 ++++++++++++++++------------------------
> 5 files changed, 76 insertions(+), 121 deletions(-)
ACK, I didn't realize we still had code using this.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list