[libvirt] [PATCH 2/7] Don't bind mount onto a char device for /dev/ptmx in LXC

Eric Blake eblake at redhat.com
Mon Jan 23 22:19:57 UTC 2012


On 01/11/2012 09:33 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
> 
> The current setup code for LXC is bind mounting /dev/pts/ptmx
> ontop of a character device /dev/ptmx. This is denied by SELinux

s/ontop/on top/

> policy and is just wrong. The target of a bind mount should just
> be a plain file
> 
> * src/lxc/lxc_container.c: Don't bind /dev/pts/ptmx onto
>   a char device
> ---
>  src/lxc/lxc_container.c |   23 ++++++++++++++---------
>  1 files changed, 14 insertions(+), 9 deletions(-)

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120123/c2a4b9f3/attachment-0001.sig>


More information about the libvir-list mailing list