[libvirt] [PATCHv2] schema: Relax schema for domain name
Eric Blake
eblake at redhat.com
Wed Jan 25 16:23:27 UTC 2012
On 01/25/2012 08:49 AM, Peter Krempa wrote:
> The domain schema enforced restrictions on the domain name string that
> the code doesn't. This patch relaxes the check, leaving the restrictions
> on the driver or hypervisor. The only invalid character is a newline.
> ---
> docs/schemas/domaincommon.rng | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index 4fa968d..ecf3484 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -3030,7 +3030,7 @@
> </define>
> <define name="domainName">
> <data type="string">
> - <param name="pattern">[A-Za-z0-9_\.\+\-&:/]+</param>
> + <param name="pattern">[^\n]+</param>
Also, an empty name is forbidden both pre- and post-patch. I agree that
any further restrictions should come from the drivers, so I'm okay giving:
ACK
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120125/cfa9fc91/attachment-0001.sig>
More information about the libvir-list
mailing list