[libvirt] [PATCH] storage: Fix any VolLookupByPath if we have an empty logical pool
Eric Blake
eblake at redhat.com
Wed Jan 25 18:23:20 UTC 2012
On 01/25/2012 11:15 AM, Cole Robinson wrote:
> On F16 at least, empty volume groups don't have a directory under /dev.
> The directory only appears once a logical volume is created.
>
> This tickles some behavior in BackendStablePath which ends with
> libvirt sleeping for 5 seconds while waiting for the directory to appear.
> This causes all sorts of problems for the virStorageVolLookupByPath API
> which virtinst uses, even if trying to resolve a path that is independent
> of the logical pool.
>
> In reality we don't even need to do that checking since logical pools
> always have a stable target path. Short circuit the polling in that
> case.
>
> Fixes bug 782261
> ---
> src/storage/storage_backend.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
ACK. Isn't it funny how small a patch can be in proportion to the time
it took you to analyze why that one if statement is needed?
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120125/ff6c2f6a/attachment-0001.sig>
More information about the libvir-list
mailing list