[libvirt] [PATCH 4/6] conf: relocate rombar and boot order parse/format
Eric Blake
eblake at redhat.com
Thu Jan 26 03:02:43 UTC 2012
On 01/25/2012 09:58 AM, Laine Stump wrote:
> Since these two items are now in the virDomainDeviceInfo struct, it
> makes sense to parse/format them in the functions written to
> parse/format that structure. Not all types of devices allow them, so
> two internal flags are added to indicate when it is appropriate to do
> so.
>
> I was lucky - only one test case needed to be re-ordered!
> ---
> src/conf/domain_conf.c | 224 +++++++++++---------
> tests/qemuxml2argvdata/qemuxml2argv-boot-order.xml | 2 +-
> 2 files changed, 123 insertions(+), 103 deletions(-)
ACK. Nice use of internal flags to share logic while still keeping the
overall parsing and output the same.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120125/25ee05e7/attachment-0001.sig>
More information about the libvir-list
mailing list