[libvirt] [libvirt-glib] Add virStorageVolResize()
Daniel P. Berrange
berrange at redhat.com
Mon Jan 30 10:57:26 UTC 2012
On Sat, Jan 28, 2012 at 02:49:46AM +0200, Zeeshan Ali (Khattak) wrote:
> On Sat, Jan 28, 2012 at 1:17 AM, Eric Blake <eblake at redhat.com> wrote:
> > On 01/26/2012 10:29 PM, Zeeshan Ali (Khattak) wrote:
>
> >> +/**
> >> + * virStorageVolResize:
> >> + * @vol: pointer to storage volume
> >> + * @capacity: new capacity
> >
> > In what units? virDomainBlockResize used kbytes as the unit,
>
> Shouldn't that be implicit unless specified otherwise in the docs? I
> am fine with or without explicit docs.
Given that virStorageVolInfo works in bytes, then I'd say we should
use bytes here too.
It is a shame we used kbytes for virDomainBlockResize.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list