[libvirt] g_error considered harmful

Christophe Fergeau cfergeau at redhat.com
Tue Jan 31 11:14:08 UTC 2012


On Mon, Jan 30, 2012 at 07:22:54PM +0100, Marc-André Lureau wrote:
> Hi
> 
> In general I agree with the patch series dropping g_error() in favour
> of normal GError reporting, so programs can cope with errors.
> 
> However, it removes the forced logging and it's too easy for the
> caller to ignore them, making it hard to track down when something
> goes wrong.

I added a patch to the series to add a g_warn_if_reached when this is
triggered

> 
> I think this is even more relevant, because libvirt-glib is logging
> *tons* of normal/useless runtime messages

To be honest I didn't really notice that... What kind of useless messages
are you getting ?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120131/95d1b5c0/attachment-0001.sig>


More information about the libvir-list mailing list