[libvirt] [PATCH] qemu_agent: support guest-info command

[Eric Blake]

On 07/04/2012 07:30 AM, Michal Privoznik wrote:
> [I am pasting your patch here so I can point out some nits]
> 
> On 03.07.2012 02:56, MATSUDA, Daiki wrote:

Missing a diffstat (git send-email can make this easier to do, and a
diffstat helps review).  Also, I'd break this into multiple commits; the
API addition in include/ should be separate from the remote driver
implementation in src/remote should be separate from the qemu
implementation in src/qemu.

> 
> For future version, can you please utilize git and git-send-email? It makes review simpler. Thanks.
> 

Other tips - don't forget to run 'make syntax-check'.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120704/a3c616fa/attachment-0001.sig>