[libvirt] [PATCH] Fix /domain/features setting in qemuParseCommandLine

Christophe Fergeau cfergeau at redhat.com
Wed Jul 11 07:12:02 UTC 2012


On Tue, Jul 10, 2012 at 04:04:12PM +0200, Michal Privoznik wrote:
> 
> Cool, so now we don't overwrite PAE feature set just a few lines above (not visible in this diff though).
> 
> ACK with this squashed in:

I have now pushed this patch with the testcase update. Before pushing I
have tested that without my patch the test fails, and after applying it the
test succeeds.

Christophe

> 
> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-kvmclock.xml b/tests/qemuxml2argvdata/qemuxml2argv-kvmclock.xml
> index e07c1f6..8abcb51 100644
> --- a/tests/qemuxml2argvdata/qemuxml2argv-kvmclock.xml
> +++ b/tests/qemuxml2argvdata/qemuxml2argv-kvmclock.xml
> @@ -8,6 +8,9 @@
>      <type arch='i686' machine='pc'>hvm</type>
>      <boot dev='network'/>
>    </os>
> +  <features>
> +    <pae/>
> +  </features>
>    <clock offset='utc'>
>      <timer name='kvmclock' present='no'/>
>    </clock>
> 
> 
> Michal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120711/6d23c2b6/attachment-0001.sig>


More information about the libvir-list mailing list