[libvirt] [PATCH v2] rpc: remove trailing whitespace character in error string

Guannan Ren gren at redhat.com
Thu Jul 19 03:21:09 UTC 2012


On 07/19/2012 12:16 AM, Eric Blake wrote:
> On 07/18/2012 09:23 AM, Guannan Ren wrote:
>> Instead of only removing the ending newline character, it is
>> better to remove all of standard whitespace character for the
>> sake of log format.
>>
>> One example that we have to do this is:
>> After three times incorrect password input, virsh command
>> virsh -c qemu://remoteserver/system will report error like:
>>
>> : Connection reset by peerey,gssapi-keyex,gssapi-with-mic,password).
>>
>> But it should be:
>> Permission denied (publickey,gssapi-keyex,gssapi-with-mic,password).
>> : Connection reset by peer
>>
>> The reason is that we dropped the newline, but have a '\r' left.
>> The terminal interprets it as "move the cursor back to the start
>> of the current line", so the error string is messed up.
> ACK.
>

      Thanks and pushed.





More information about the libvir-list mailing list