[libvirt] [PATCH v2 1/3] Use standard naming prefix for SELinux driver function names
Daniel P. Berrange
berrange at redhat.com
Fri Jul 20 19:18:04 UTC 2012
On Fri, Jul 20, 2012 at 11:06:40AM -0600, Eric Blake wrote:
> On 07/20/2012 10:59 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange at redhat.com>
> >
> > The function names in the SELinux driver all start with
> > SELinux or 'mcs' as a prefix. Sanitize this so that they
> > all use 'virSecuritySELinux' as the prefix
> >
> > Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> > ---
> > src/security/security_selinux.c | 394 ++++++++++++++++++++-------------------
> > 1 file changed, 198 insertions(+), 196 deletions(-)
>
> Mechanical. ACK.
>
> > @@ -487,12 +489,12 @@ SELinuxSecurityDriverClose(virSecurityManagerPtr mgr)
> > }
> >
> >
> > -static const char *SELinuxSecurityGetModel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED)
> > +static const char *virSecuritySELinuxSecurityGetModel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED)
>
> For hunks like this, do you want to reformat to:
>
> static const char *
> virSecuritySELinuxSecurityGetModel(virSecurityManagerPtr mgr
> ATTRIBUTE_UNUSED)
>
> to avoid the long lines? But that's cosmetic, and doesn't get in the
> way of my ack.
Yes, I've fixed the long lines here
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list