[libvirt] [PATCH] virsh: Clarify that memtune parameters may be rounded in the man page
Eric Blake
eblake at redhat.com
Tue Jul 24 21:35:37 UTC 2012
On 07/24/2012 02:50 AM, Jan Tomko wrote:
> ---
> tools/virsh.pod | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index b4a3d5c..6ecf6ce 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -1366,7 +1366,10 @@ appropriate limit is adjusted if supported by the hypervisor. LXC and
> QEMU/KVM support I<--hard-limit>, I<--soft-limit>, and I<--swap-hard-limit>.
> I<--min-guarantee> is supported only by ESX hypervisor. Each of these
> limits are scaled integers (see B<NOTES> above), with a default of
> -kibibytes (blocks of 1024 bytes) if no suffix is present.
> +kibibytes (blocks of 1024 bytes) if no suffix is present. Libvirt rounds
> +up to the nearest kibibyte. Some hypervisors require a larger granularity
> +than KiB, and requests that are not an even multiple will be rounded up.
> +For example, vSphere/ESX rounds the parameter up to mebibytes (1024 kibibytes).
ACK (I had to check the code to make sure).
Pushed, after adding you to AUTHORS.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120724/3bf71b04/attachment-0001.sig>
More information about the libvir-list
mailing list