[libvirt] [PATCH v3 0/2] capture network traffic
hendrik at os-t.de
Mon Jul 30 07:34:56 UTC 2012
it would be nice if someone could have a short look at my patch. I'm not
quite sure if i did the error handling correct and how to avoid the "end
of file while reading data" error.
On 26.07.2012 13:15, Hendrik Schwartke wrote:
> Thanks again for your comments on the prototype.
> I moved a good portion of the patch to src/util/virnetdevcapture.c and left only
> a simple stub in src/interface/netcf_driver.c. I think that this is now a much
> cleaner implementation.
> The docs are still missing. Futhermore I don't know how to avoid the
> "End of file while reading data" error when closing the stream.
> So, please review the whole thing.
> Hendrik Schwartke (2):
> Add virNetDevCapture
> Add the command iface-capture to virsh
> include/libvirt/libvirt.h.in | 13 +++
> src/Makefile.am | 1 +
> src/driver.h | 8 ++
> src/interface/netcf_driver.c | 15 ++-
> src/libvirt.c | 51 +++++++++
> src/libvirt_private.syms | 4 +
> src/libvirt_public.syms | 5 +
> src/remote/remote_driver.c | 1 +
> src/remote/remote_protocol.x | 10 +-
> src/util/virnetdevcapture.c | 251 ++++++++++++++++++++++++++++++++++++++++++
> src/util/virnetdevcapture.h | 32 ++++++
> tools/virsh.c | 87 +++++++++++++++
> 12 files changed, 476 insertions(+), 2 deletions(-)
> create mode 100644 src/util/virnetdevcapture.c
> create mode 100644 src/util/virnetdevcapture.h
More information about the libvir-list