[libvirt] [PATCH 2/3] Don't link nwfilter or secrets driver to libvirt.so
Eric Blake
eblake at redhat.com
Tue Jul 31 23:48:26 UTC 2012
On 07/31/2012 04:06 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> The nwfilter and secrets drivers are both stateful and are already
> linked directly to libvirtd. Linking them to libvirt.so is thus
> wrong, likewise exporting their symbols in libvirt.so is wrong
> ---
> src/Makefile.am | 11 ++++-------
> src/libvirt_nwfilter.syms | 12 ------------
> src/libvirt_private.syms | 31 -------------------------------
> 3 files changed, 4 insertions(+), 50 deletions(-)
> delete mode 100644 src/libvirt_nwfilter.syms
Unfortunately, this patch breaks 'make check', although I haven't
figured out why:
$ make && make -C tests check TESTS=virdrivermoduletest VIR_TEST_DEBUG=1
...
TEST: virdrivermoduletest
1) Test driver "network" ... OK
2) Test driver "storage" ... OK
3) Test driver "nodedev" ... OK
4) Test driver "secret" ... OK
5) Test driver "nwfilter" ... OK
6) Test driver "interface" ... OK
7) Test driver "qemu"
... FAILED
8) Test driver "lxc"
... FAILED
9) Test driver "uml" ... OK
FAIL: virdrivermoduletest
=======================================
1 of 1 test failed
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120731/165fd527/attachment-0001.sig>
More information about the libvir-list
mailing list