[libvirt] [PATCH] qemu: Move -name arg to be the 1st so it's visible in "ps x"
Eric Blake
eblake at redhat.com
Fri Jun 1 21:08:00 UTC 2012
On 06/01/2012 02:45 PM, Marti Raudsepp wrote:
> On Fri, Jun 1, 2012 at 10:30 PM, Eric Blake <eblake at redhat.com> wrote:
>> Once you get down to no args, it's more efficient to do:
>>
>> virCommandNew(emulator);
>>
>> And one BIIIIG problem - making this change means that 'make check'
>> fails, unless you update ALL of the tests to match.
Thankfully, we had very few named VMs in our testsuite - I only had to
touch 15 files.
>
> Oops, obviously I'm new to libvirt development. :)
>
>> ACK with those modifications, so I will push once I complete the
>> testsuite conversion. I will also be adding you to AUTHORS; let me know
>> if you prefer a different spelling than what you used to make your commit.
>
> Thanks, this ID is good.
Good to know. Pushed now.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120601/d3412497/attachment-0001.sig>
More information about the libvir-list
mailing list