[libvirt] [PATCH] fix make syntax-check failed

Eric Blake eblake at redhat.com
Mon Jun 4 17:26:10 UTC 2012


On 06/04/2012 07:19 AM, Eric Blake wrote:
> On 06/04/2012 04:29 AM, Michal Privoznik wrote:
>> On 04.06.2012 05:37, Wen Congyang wrote:
>>> ---
>>>  tools/virsh.c |  170 ++++++++++++++++++++++++++++----------------------------
>>>  1 files changed, 85 insertions(+), 85 deletions(-)
>>>

>> Therefore we need slightly different approach:
>>
>> https://www.redhat.com/archives/libvir-list/2012-June/msg00055.html
>>
>> Maybe others should step in and share their opinions.
> 
> I actually prefer Wen's solution, and think it is better to be
> consistent with # processing even if it looks odd in function context.
> 
> ACK to Wen's version.

And I've now pushed it, under the build-breaker rule.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120604/94d17b45/attachment-0001.sig>


More information about the libvir-list mailing list