[libvirt] [patch]make rundir permission equals to socket permission to support unprivileged access

[Royce Lv]

2012/6/5 Dave Allan <dallan at redhat.com>

> On Tue, Jun 05, 2012 at 02:21:10PM +0800, Royce Lv wrote:
> > Libvirt-socket-rw and libvirt-socket-ro are not used only for libvirt or
> > root user,
> > but also for  unprivileged application such as vdsm,
> > Restrain the rundir only read/search for libvirt prevent comunication
> > with unprivileged client,change rundir the permission equals to the
> sockets
> > permission.
> > See bug:
> > https://bugzilla.redhat.com/show_bug.cgi?id=828073
>
> That BZ is marked as a Regression; do you know if that's right, and if
> so, what commit caused it?
>
2012/6/5 Dave Allan <dallan at redhat.com>

> On Tue, Jun 05, 2012 at 02:21:10PM +0800, Royce Lv wrote:
> > Libvirt-socket-rw and libvirt-socket-ro are not used only for libvirt or
> > root user,
> > but also for  unprivileged application such as vdsm,
> > Restrain the rundir only read/search for libvirt prevent comunication
> > with unprivileged client,change rundir the permission equals to the
> sockets
> > permission.
> > See bug:
> > https://bugzilla.redhat.com/show_bug.cgi?id=828073
>
> That BZ is marked as a Regression; do you know if that's right, and if
> so, what commit caused it?
>
I guess it should be this one:
commit:
32a9aac2e04c991340b66c855a1095e4e6445e54


>
> Dave
>
> > Signed-off-by: lvroyce <lvroyce at linux.vnet.ibm.com>
> > ---
> >  daemon/libvirtd.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
> > index c74cd43..6095072 100644
> > --- a/daemon/libvirtd.c
> > +++ b/daemon/libvirtd.c
> > @@ -293,7 +293,7 @@ daemonUnixSocketPaths(struct daemonConfig *config,
> >              if (!(rundir = virGetUserRuntimeDirectory()))
> >                  goto error;
> >
> > -            old_umask = umask(077);
> > +            old_umask = umask(022);
> >              if (virFileMakePath(rundir) < 0) {
> >                  umask(old_umask);
> >                  goto error;
>
> > --
> > libvir-list mailing list
> > libvir-list at redhat.com
> > https://www.redhat.com/mailman/listinfo/libvir-list
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120607/8e297b6e/attachment-0001.htm>