[libvirt] pointless time-consuming test 'virsh-all'

[Martin Kletzander]

On 06/07/2012 05:32 AM, Eric Blake wrote:
> The command 'make -C tests check' takes forever, because it is calling
> this lengthy virsh command and ignoring the failures:
> 
> $ time tools/virsh -c test:///default connect
> error: Failed to connect to the hypervisor
> error: Failed to connect socket to
> '/run/user/eblake/libvirt/libvirt-sock': No such file or directory
> 
> 
> real	0m21.070s
> user	0m0.027s
> sys	0m0.036s
> 
> The test looks quite broken - ALL it is currently doing is wasting 21
> seconds on this one iteration, because it ignores output and exit status
> (what else _is_ there, besides effects to the file system)?
> 
> Any volunteers to clean this test up into something that actually does
> something useful?
> 

I'd like to help out but I don't see any problem. When I run 'make -C
tests check', there is no test that takes more than a second and the
whole make check is done in under 50 seconds.

This is what I get when running the same as you did:

$ time tools/virsh -c test:///default connect


real	0m0.048s
user	0m0.024s
sys	0m0.022s


Let me know if there are any details I missed.

Have a nice day,
Martin