[libvirt] [PATCH] snapshot: avoid virsh crash with older servers
Eric Blake
eblake at redhat.com
Mon Jun 11 14:51:57 UTC 2012
On 06/10/2012 09:58 PM, Osier Yang wrote:
> On 2012年06月09日 01:56, Eric Blake wrote:
>> Commits 51082301, 16d7b39, and 521cc447 introduced support for
>> 'virsh snapshot-list --from' when talking to a server older than
>> 0.9.5, but broke support for plain 'virsh snapshot-list' for the
>> same old server in the process. Because the code is not properly
>> gated, we end up with a SIGSEGV during a strcmp with a NULL argument.
>>
>> * tools/virsh.c (cmdSnapshotList): Don't waste time on fallbacks
>> when --from is not present.
>
> ACK.
Thanks; pushed.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120611/93ef883f/attachment-0001.sig>
More information about the libvir-list
mailing list