[libvirt] [PATCH 2/6] virsh: remove limits on tree listing
Eric Blake
eblake at redhat.com
Mon Jun 11 16:20:46 UTC 2012
On 06/11/2012 06:31 AM, Peter Krempa wrote:
> On 06/09/12 06:34, Eric Blake wrote:
>> I am not a fan of fixed-width buffers. All it takes is a
>> linear chain of more than 100 snapshots to mess up 'virsh
>> snapshot-list --tree'. Now that virBuffer is more powerful,
>> we might as well exploit its power.
>>
>> * tools/virsh.c (cmdNodeListDevicesPrint): Simplify to use a
>> virBuffer instead of fixed-width prefix, factor guts, and rename...
>> (vshTreePrint, vshTreePrintInternal): ...along with new helper.
>> (cmdNodeListDevices, cmdSnapshotList): Update callers.
>> ---
>
> ACK, great improvement in code understandability.
Thanks; pushed.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120611/4060e8a3/attachment-0001.sig>
More information about the libvir-list
mailing list