[libvirt] [PATCHv2 variant 2] snapshot: implement new APIs for esx and vbox

[Osier Yang]

On 2012年06月12日 06:08, Eric Blake wrote:
> The two new APIs are rather trivial; based on bits and pieces of
> other existing APIs.  I chose to blindly return 0 for HasMetadata,
> since we already do that for other APIs like domainIsPersistent.
>
> * src/esx/esx_driver.c (esxDomainSnapshotIsCurrent)
> (esxDomainSnapshotHasMetadata): New functions.
> * src/vbox/vbox_tmpl.c (vboxDomainSnapshotIsCurrent)
> (vboxDomainSnapshotHasMetadata): Likewise.
> ---
>
> This version avoids existence checks.  I don't like it, but it is
> shorter, so it's worth posting.

I'd like ACK this one, personally I think checking if the object
exists or not should replies on the apps, we have the APIs to
lookup if the object exists or not.

Osier