[libvirt] [PATCH 5/6] snapshot: new virsh function factored from snapshot-list
Eric Blake
eblake at redhat.com
Wed Jun 13 22:33:15 UTC 2012
On 06/12/2012 06:42 PM, Eric Blake wrote:
>> I really need to list this as a comment. I'll post a v2, adding
>> comments and including your improvements.
>
> Here's what I'll squash for my v2:
>
> + /* First, determine if we can use the new child listing API. */
> + if (!ctl->useSnapshotOld &&
> + (count = virDomainSnapshotNumChildren(from, flags) < 0) &&
Ouch - nasty typo on my part in transcribing Peter's suggestions (hint -
')' in the wrong place). All the more reason for me to post a corrected v2.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120613/b6edb106/attachment-0001.sig>
More information about the libvir-list
mailing list